Skip to content

chore: Remove anthos-dpe from owners#8271

Merged
suztomo merged 1 commit into
mainfrom
issue-remove-anthos-dpe-owners
Sep 7, 2022
Merged

chore: Remove anthos-dpe from owners#8271
suztomo merged 1 commit into
mainfrom
issue-remove-anthos-dpe-owners

Conversation

@olivi-eh

@olivi-eh olivi-eh commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@olivi-eh olivi-eh requested review from a team and donmccasland September 1, 2022 17:55
This was referenced Sep 1, 2022
Merged
Merged
Merged
Merged
@olivi-eh olivi-eh changed the title Remove anthos-dpe from owners chore: Remove anthos-dpe from owners Sep 1, 2022
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Sep 1, 2022

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@olivi-eh olivi-eh force-pushed the issue-remove-anthos-dpe-owners branch from 39026a7 to 1a06768 Compare September 1, 2022 18:07
@olivi-eh olivi-eh added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022
@olivi-eh olivi-eh requested a review from suztomo September 6, 2022 15:53
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2022
@suztomo

suztomo commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I don't think #8271 is necessary, as CODEOWNERS file in java-container is not recognized by GitHub. It's just copied from java-container:

To use a CODEOWNERS file, create a new file called CODEOWNERS in the root, docs/, or .github/ directory of the repository

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

(But no harm to merging this PR, just to be consistent with googleapis/java-container#779

@suztomo suztomo closed this Sep 7, 2022
@suztomo suztomo reopened this Sep 7, 2022
@suztomo suztomo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022
meltsufin
meltsufin approved these changes Sep 7, 2022
View reviewed changes

@meltsufin meltsufin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that @googleapis/java-samples-reviewers doesn't exist.

@suztomo

suztomo commented Sep 7, 2022

Copy link
Copy Markdown
Member

The team exists but not having Write access to this repository.

@suztomo suztomo merged commit d872e63 into main Sep 7, 2022
@suztomo suztomo deleted the issue-remove-anthos-dpe-owners branch September 7, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo Awaiting requested review from suztomo

2 more reviewers

@donmccasland donmccasland donmccasland approved these changes

@meltsufin meltsufin meltsufin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@olivi-eh @suztomo @donmccasland @meltsufin @yoshi-kokoro